View Issue Details

IDProjectCategoryView StatusLast Update
0010967mantisbtcode cleanuppublic2009-10-07 14:19
ReporterDanez Assigned Todhx  
PrioritylowSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.2.0rc2Fixed in Version1.2.0rc2 
Summary0010967: Remove ini_set()'s as this function is often blocked by hoster
Description

In several locations of the code ini_set is used, mostly in external libraries.

Replacing the ones in the mantiscore with php-core functions if possible.
Otherwise try to remove them or check if function exists.

Additional Information

ini_set( 'magic_quotes_runtime', 0 ); => set_magic_quotes_runtime(false);

if(function_exists('ini_set'))
....

Tagspatch

Activities

Danez

Danez

2009-09-20 09:01

reporter   ~0022988

This commit fixes the core functions, but not the external libraries:
http://git.mantisforge.org/w/mantisbt/dtschinder.git?a=commit;h=c09c7d327159f883268fc55456c61c7b0936d46e

dhx

dhx

2009-09-23 04:05

reporter   ~0023023

Committed, thanks!

Related Changesets

MantisBT: master-1.2.x c896ad16

2009-09-20 08:55

Danez

Committer: dhx


Details Diff
Issue 0010967: Check for existence of ini_set function before use

On some servers, the administrator may have disabled the use of the
ini_set function for security reasons (using the disabled_functions PHP
configuration option).

We should check to make sure ini_set is available before we try to call
it.

Also use set_magic_quotes_runtime() instead of doing an ini_set on the
"magic_quotes_runtime" option. This function is deprecated as of PHP
5.3.0 but at least we can do a function_exists() check on it.
Affected Issues
0010967
mod - file_download.php Diff File
mod - core/string_api.php Diff File
mod - core/php_api.php Diff File
mod - core/compress_api.php Diff File

MantisBT: master 61804a9d

2009-09-20 08:55

Danez

Committer: dhx


Details Diff
Issue 0010967: Check for existence of ini_set function before use

On some servers, the administrator may have disabled the use of the
ini_set function for security reasons (using the disabled_functions PHP
configuration option).

We should check to make sure ini_set is available before we try to call
it.

Also use set_magic_quotes_runtime() instead of doing an ini_set on the
"magic_quotes_runtime" option. This function is deprecated as of PHP
5.3.0 but at least we can do a function_exists() check on it.
Affected Issues
0010967
mod - core/string_api.php Diff File
mod - core/php_api.php Diff File
mod - file_download.php Diff File
mod - core/compress_api.php Diff File