View Issue Details

IDProjectCategoryView StatusLast Update
0010959mantisbtbugtrackerpublic2009-10-07 14:19
Reportercmfitch1 Assigned Todhx  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version1.2.0rc2Fixed in Version1.2.0rc2 
Summary0010959: Renaming a tag fails to update associated reports
Description

After a tag is renamed, associated reports are supposed to get an issue history entry indicating so. The history_log_event_special() call in tag_update() passes the wrong variable in for the tag name, causing a database error to occur.

Tagspatch
Attached Files
issue_10959.patch (684 bytes)   
From 05826fdc9d735e8c0235dd5ba10c8efbe3a3f3b2 Mon Sep 17 00:00:00 2001
From: Chris Fitch <cfitch@redcom.com>
Date: Thu, 17 Sep 2009 11:20:55 -0400
Subject: [PATCH] Fix tag update history logging


diff --git a/core/tag_api.php b/core/tag_api.php
index 62f223d..c1d9dd2 100644
--- a/core/tag_api.php
+++ b/core/tag_api.php
@@ -362,7 +362,7 @@ function tag_update( $p_tag_id, $p_name, $p_user_id, $p_description ) {
 		$t_bugs = tag_get_bugs_attached( $p_tag_id );
 
 		foreach( $t_bugs as $t_bug_id ) {
-			history_log_event_special( $t_bug_id, TAG_RENAMED, $t_tag_name, $c_name );
+			history_log_event_special( $t_bug_id, TAG_RENAMED, $t_tag_name, $p_name );
 		}
 	}
 
-- 
1.6.0.4

issue_10959.patch (684 bytes)   

Activities

dhx

dhx

2009-09-22 03:24

reporter   ~0023005

Committed, thanks!

Related Changesets

MantisBT: master-1.2.x e93ab8b4

2009-09-17 11:20

Chris Fitch

Committer: dhx


Details Diff
Fix 0010959: Incorrect variable name in tag_update function

After a tag is renamed, associated reports are supposed to get an issue
history entry indicating so. The history_log_event_special() call in
tag_update() passes the wrong variable in for the tag name, causing a
database error to occur.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010959
mod - core/tag_api.php Diff File

MantisBT: master ca9b4def

2009-09-17 11:20

Chris Fitch

Committer: dhx


Details Diff
Fix 0010959: Incorrect variable name in tag_update function

After a tag is renamed, associated reports are supposed to get an issue
history entry indicating so. The history_log_event_special() call in
tag_update() passes the wrong variable in for the tag name, causing a
database error to occur.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0010959
mod - core/tag_api.php Diff File