|Anonymous | Login | Signup for a new account||2014-08-22 19:35 EDT|
|My View | View Issues | Change Log | Roadmap | Wiki | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0010675||mantisbt||time tracking||public||2009-07-03 04:08||2013-04-27 16:50|
|Priority||normal||Severity||feature||Reproducibility||have not tried|
|Target Version||Fixed in Version|
|Summary||0010675: Made enhancement to the billing page|
|Description||we made some enhancements to the billing page and add the patches for|
Mantis BT V 1.1.4 (which we are currently using) and the latest Mantis
- added new listbox where you can select ONE reporter for which you want
the billing; alternatively you can get the report for ALL reporters;
this is the default and same as the known behaviour
- the listbox is only visible for users with the appropriate rights
(configurable in the config file)
- users which can generate reports (thus visit the reporting page) but
do not have that right, just get a report for themselves
|Tags||2.0.x check, patch|
|Attached Files|| mantisbt--1.2.0a2-2009-07-02-master-4eaeb80.diff [^] (8,154 bytes) 2009-07-03 04:08 [Show Content]
mantisbt-1.1.4.diff [^] (7,045 bytes) 2009-07-03 04:08 [Show Content]
TimeReport1.png [^] (65,747 bytes) 2009-08-03 09:46
TimeReport2.png [^] (71,142 bytes) 2009-08-03 09:46
mantisbt-1.1.4-version2.diff [^] (7,073 bytes) 2009-08-03 09:47 [Show Content]
mantisbt-1.2.0rc2-2009-08-03-master-1.2.x-e4c9e22.diff [^] (7,804 bytes) 2009-08-03 09:48 [Show Content]
Thanks @reinform for the contribution. Here are some comments:
1. It would be nice to include a screenshot.
2. bugnote_stats_get_project_array - move the new parameter to be the last one and default it to the value that provides the previous behavior (ALL_USERS?). We should attempt to avoid breaking the API.
3. Why do you use the print_assign_to_option_list() to print the list of reporters? This will print the list of developers.
|Actually, I'm probably wrong with point 3, since you are referring to the reporter of the note, not the reporter of the issue. In this case, assuming that developers are the only ones who can log time, then you will get the right list. I haven't looked in details, but we should make sure the list is the same as the list of people who are allowed to report time.|
Hello, sorry for the late reply, i just now could come back here.
Thank you very much for your advice. I followed your suggestions.
Essentially i changed
"print_assign_to_option_list" to "print_reporter_option_list",
"$f_reporter_id" to the end of "bugnote_stats_get_project_array"
"$p_reporter_id = ALL_USERS"
in the proper function.
Two screen shots are included, which show the behaviour for
a) a user that can generate reports, but is not allowed to select a reporter
b) one that can generate reports AND select the reporter of bug notes
Also find enclosed two corresponding patches, one for Mantis BT V 1.1.4 (which we are currently using) and one for V 1.2.0rc2-2009-08-03-master-1.2.x-e4c9e22 (which i downloaded today).
Thanks for the patch, this looks quite useful!
My only concern is why there is a need for a new configuration option "time_tracking_reporting_select_reporter_threshold"? This seems fairly useless to me. Why can't we just give everyone (who has access to the billing page) the ability to filter by reporter?
in our company we use Mantis for several purposes and one of those is to manage ToDo's regarding work for our clients. We track the time the developers need for their ToDo items and use it for accounting. The data is used to invoice clients as well as for the payment of developers. For privacy reasons a developer should just be able to generate reports of his own used time, not reports regarding other reporters. This functionality is limited to the manager and the accounting staff. From this point of view it seemed useful to have the new configuration option "time_tracking_reporting_select_reporter_threshold".
The billing page shows issues regardlesss of their status (new,assigned, reslolved, closed etc.) I would love to heve another filtering crieria here that would allow filter issues on billing page by their status (either using checkboxes or drop down combo box). As it is quite important to track time / do billing, for closed issuess only.
|This is partly what we need. How come during more than two years, it hasn't made its way to the core?|
Ability to filter by user added.
Note: Haven't added a configuration variable to control this - ideally i'd probably say that a developer should be able to see his own [he could add it up manually], and the existing manager rights should therefre be able to see 'any'.
|Reopened as the code is not available in the master branch in github|
|this is fixed in the mantis-2.x branch|
|Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch|
|2009-07-03 04:08||reinform||New Issue|
|2009-07-03 04:08||reinform||File Added: mantisbt--1.2.0a2-2009-07-02-master-4eaeb80.diff|
|2009-07-03 04:08||reinform||File Added: mantisbt-1.1.4.diff|
|2009-07-04 00:20||vboctor||Tag Attached: patch|
|2009-07-04 00:27||vboctor||Note Added: 0022373|
|2009-07-04 00:29||vboctor||Note Added: 0022374|
|2009-08-03 09:45||reinform||Note Added: 0022649|
|2009-08-03 09:46||reinform||File Added: TimeReport1.png|
|2009-08-03 09:46||reinform||File Added: TimeReport2.png|
|2009-08-03 09:47||reinform||File Added: mantisbt-1.1.4-version2.diff|
|2009-08-03 09:48||reinform||File Added: mantisbt-1.2.0rc2-2009-08-03-master-1.2.x-e4c9e22.diff|
|2009-10-28 20:24||dhx||Note Added: 0023455|
|2009-10-28 20:24||dhx||Status||new => acknowledged|
|2009-10-29 19:13||reinform||Note Added: 0023477|
|2010-09-09 05:17||mikrot||Note Added: 0026640|
|2011-12-14 03:22||rombert||Severity||minor => feature|
|2011-12-23 23:39||AbsolutelyFreeWeb||Note Added: 0030682|
|2011-12-24 09:02||dregad||Relationship added||has duplicate 0008871|
|2011-12-31 04:22||AbsolutelyFreeWeb||Relationship added||related to 0013705|
|2012-01-22 06:23||grangeway||Note Added: 0030992|
|2012-01-22 06:23||grangeway||Status||acknowledged => resolved|
|2012-01-22 06:23||grangeway||Fixed in Version||=> 1.3.x|
|2012-01-22 06:23||grangeway||Resolution||open => fixed|
|2012-01-22 06:23||grangeway||Assigned To||=> grangeway|
|2012-03-15 07:47||dregad||Note Added: 0031474|
|2012-03-15 07:47||dregad||Status||resolved => feedback|
|2012-03-15 07:47||dregad||Resolution||fixed => reopened|
|2012-10-20 19:59||grangeway||Note Added: 0033291|
|2012-10-20 19:59||grangeway||Status||feedback => resolved|
|2012-10-20 19:59||grangeway||Resolution||reopened => fixed|
|2013-04-05 17:56||grangeway||Status||resolved => acknowledged|
|2013-04-05 17:56||grangeway||Note Added: 0036220|
|2013-04-05 18:57||grangeway||Relationship added||related to 0015721|
|2013-04-06 09:26||dregad||Tag Attached: 2.0.x check|
|2013-04-06 09:26||dregad||Status||acknowledged => resolved|
|2013-04-06 10:31||dregad||Assigned To||grangeway =>|
|2013-04-06 10:31||dregad||Status||resolved => acknowledged|
|2013-04-06 10:31||dregad||Fixed in Version||1.3.x =>|
|2013-04-06 15:18||grangeway||Status||acknowledged => resolved|
|2013-04-06 15:18||grangeway||Assigned To||=> grangeway|
|2013-04-27 16:50||atrol||Assigned To||grangeway =>|
|2013-04-27 16:50||atrol||Status||resolved => new|
|2013-04-27 16:50||atrol||Resolution||fixed => open|
| MantisBT 1.2.17 [^]
Copyright © 2000 - 2014 MantisBT Team
Time: 0.0981 seconds.|
memory usage: 3,183 KB