Mantis Bug Tracker
 

View Issue Details Jump to Notes ] Wiki ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010453mantisbttime trackingpublic2009-05-05 02:192009-06-26 12:00
Reporterdhx 
Assigned Tojreese 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Versiongit trunk 
Target VersionFixed in Version 
Summary0010453: Time tracking billing menu link should show for those with read only access to billing data
DescriptionCurrently this check is performed in core/html_api.php when printing the billing link to the main navigation bar:

access_has_global_level( config_get( 'time_tracking_reporting_threshold' ) )

This check should actually be:

access_has_global_level( config_get( 'time_tracking_view_threshold' ) )

So that those with read only access to billing data can also view the billing page.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
User avatar (0021774)
dhx (developer)
2009-05-05 02:30

The two line fix can be pulled from branch 10453 at git://git.mantisforge.org/mantisbt/dhx.git [^]
User avatar (0021795)
jreese (administrator)
2009-05-08 09:10

Marking as resolved based on IRC conversation:

09:07 < nuclear_eclipse> dhx_m: I have to disagree with 10453
09:07 < dhx_m> hmm really?
09:07 < nuclear_eclipse> it seems correct the way it currently is
09:08 < nuclear_eclipse> the threshold it uses it specifically defined as users running reports

09:08 < nuclear_eclipse>     /**
09:08 < nuclear_eclipse>      * access level required to run reports
09:08 < nuclear_eclipse>      * @global int $g_time_tracking_reporting_threshold
09:08 < nuclear_eclipse>      */
09:08 < nuclear_eclipse>     $g_time_tracking_reporting_threshold = MANAGER;
09:08 < dhx_m> oh oops
09:08 < dhx_m> I thought it was who could track time
09:08 < dhx_m> rather than who could create reports
09:08 < nuclear_eclipse> hehe, the name is confusing...
09:09 < nuclear_eclipse> $g_time_tracking_edit_threshold is the one you were thinking of
09:09 < dhx_m> ah doh :)
09:09 < dhx_m> in that case, I'll delete the branch :)
09:09 < dhx_m> thanks for the heads up
09:09 < nuclear_eclipse> np, I'll mark the issue appropriately

- Issue History
Date Modified Username Field Change
2009-05-05 02:19 dhx New Issue
2009-05-05 02:30 dhx Note Added: 0021774
2009-05-08 09:10 jreese Note Added: 0021795
2009-05-08 09:10 jreese Status new => resolved
2009-05-08 09:10 jreese Resolution open => no change required
2009-05-08 09:10 jreese Assigned To => jreese
2009-06-26 12:00 vboctor Status resolved => closed


MantisBT 1.2.2 git master-1.2.x[^]
Copyright © 2000 - 2010 MantisBT Group
Time: 0.2280 seconds.
memory usage: 1,936 KB
Powered by Mantis Bugtracker