0010277: Creating tag with empty name gives "Operation succesful" - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0010277	mantisbt	administration	public	2009-03-30 18:33	2014-12-08 02:18

Reporter	siebrand	Assigned To	vboctor
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	won't fix
Product Version	git trunk

Summary	0010277: Creating tag with empty name gives "Operation succesful"
Description	Creating an empty tag results in "Operation succesful" and no tag created. Should give a "Did nothing, because no input" type of message. Appears to be incomplete input handling in tag_create.php.
Steps To Reproduce	go to manage_tags_page.php ensure "name" is empty click "Create Tag"
Tags	No tags attached.

jreese 2009-03-30 18:54 reporter ~0021309	It's not really "incomplete," considering I'd planned it to work that way on purpose. I wanted to stay within the existent behavior set for Mantis, and I didn't think giving an error or other message really added anything to the process. It might be a bit odd at first, but considering that it's possible to also have it "create" a tag with an existing name, in which case it just silently says "success" while doing nothing, the current behavior is at least consistent in that regard, and is simpler/less complex by not needing special case messages. Whether or not everyone agrees with that assessment is a different story, and I'm open to other developers' opinions.

jreese 2009-03-30 18:55 reporter ~0021310	Reminder sent to: giallu, grangeway, thraxisp, vboctor Copying in the rest of the core devs for opinions...

vboctor 2009-03-30 19:07 manager ~0021312	If you click "Add Note" with an empty or blank note, you will get the following error: A necessary field "Note" was empty. Please recheck your inputs. We could do the same with "Attach" tag with an empty tag.