View Issue Details

IDProjectCategoryView StatusLast Update
0010145mantisbtlocalizationpublic2009-06-23 15:26
ReporterKirill Assigned Tosiebrand  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
PlatformWindowsOSWindows XPOS Version1.1.0
Product Versiongit trunk 
Fixed in Version1.2.0rc1 
Summary0010145: Changelog and localisation of released
Description

in changelog_page.php not correctly showing text released on russian

I change strtolower to mb_strtolower and all work fine

Tagsutf8
Attached Files
mantis.png (1,571 bytes)   
mantis.png (1,571 bytes)   

Relationships

related to 0008763 closedsiebrand Russian characters not shown correctly 

Activities

Kirill

Kirill

2009-02-19 07:33

reporter   ~0020892

-46 $t_release_date = ' (' . strtolower( lang_get('released') ) . ' ' . date( config_get( 'short_date_format' ), $t_release_timestamp ) . ')';
+46 $t_release_date = ' (' . mb_strtolower( lang_get('released') ) . ' ' . date( config_get( 'short_date_format' ), $t_release_timestamp ) . ')';

-48 $t_release_date = ' (' . strtolower( lang_get( 'not_released' ) ) . ')';
+48 $t_release_date = ' (' . mb_strtolower( lang_get( 'not_released' ) ) . ')';

Kirill

Kirill

2009-02-19 07:40

reporter   ~0020893

in roadmap_page.php has this bug too

giallu

giallu

2009-02-19 12:55

reporter   ~0020898

I wonder why we do the strtolower thing here...

Kirill

Kirill

2009-02-19 13:26

reporter   ~0020899

I wonder too

siebrand

siebrand

2009-02-20 16:43

developer   ~0020912

In any case, should we make mb_string a required library, so that we can properly support many languages?

giallu

giallu

2009-02-20 17:00

reporter   ~0020913

that's actually a good question. The usual reply is that we don't want to require a php module which is not in the default set you get when building PHP sources.

in 1.2 we are adding a wrapper class for string functions so that we can call the mb_string variant when available and the regular one when not.

I think we could decide to also add a warning on check.php and in other places when mb_string is not present but the user selects a language other than english

Kirill

Kirill

2009-02-21 03:56

reporter   ~0020916

Last edited: 2009-03-02 15:46

This issue such as 0008763.
I cann't add relationship.

siebrand

siebrand

2009-03-26 21:56

developer   ~0021224

Not a blocker.

siebrand

siebrand

2009-06-11 06:22

developer   ~0022078

Fixed in git trunk.