MantisBT

View Issue Details Jump to Notes ] Wiki ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010130mantisbtfilterspublic2009-02-11 12:402014-09-23 18:05
Reporteratrol 
Assigned Todregad 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1.6 
Target Version1.2.13Fixed in Version1.2.13 
Summary0010130: Filter "Assigned to" does not display usernames when project "All Projects" is selected
DescriptionI want to see all issues that are assigned to one person, who is working in more than one project. I select "All Projects" from projects. Trying this, I get no list of users in field "Assigned to"
I only get [any][none][myself] and my own username in the list.
This appears using simple and advanced filtering.
Tagspatch
Attached Filespatch file icon filter-users-in-list-when-all_projects-selected.patch [^] (4,365 bytes) 2011-06-14 07:30 [Show Content]

- Relationships
related to 0015721closedgrangeway Functionality to consider porting to master-2.0.x 
has duplicate 0010280closedatrol Option to show all users in All Projects filter 
has duplicate 0012501closedatrol Can not use the "assigned to" filter properly when "all project" is selected 
related to 0015411closeddregad Huge memory consumption for print_user_option_list() 

-  Notes
User avatar (0023279)
atrol (developer)
2009-10-22 10:31

Still the same behaviour in 1.2RC2,
Maybe someone knows another way how to get this information.
User avatar (0024422)
dhx (reporter)
2010-02-18 10:34

When you're reproducing this problem, how many projects do you have in your MantisBT installation?

If the answer is 1 (one), perhaps this issue is the same as 0011509 ?
User avatar (0024428)
atrol (developer)
2010-02-18 11:15

The answer is 22 (5 of them as subprojects)
User avatar (0024435)
stevenchew (reporter)
2010-02-18 21:26
edited on: 2010-02-19 04:20

face the same issue in version 1.1.7.

I can see a list of users in "Reported" & "Monitored By" field but only 2 users in the "Assigned To" field who are administrators.

There are over 50 projects and sub projects with varying users access permissions to each projects.

User avatar (0027363)
stevecharon (reporter)
2010-11-15 07:50

Same issue on 1.2.1 - only global developers or above are selectable in all projects view.
Having over 30 projects running - it is a pain....
User avatar (0027364)
cas (reporter)
2010-11-15 08:05

same in version 1.2.3, running 30 projects of which 10 sub-projects
User avatar (0027618)
istvanb (reporter)
2010-12-16 08:16

Click to the "Main" page and click the number after the "Open and assigned to me:" this will list all of your issues and also you can sort them. It would be much better though if this could be a filter option
User avatar (0027619)
atrol (developer)
2010-12-16 09:07

Istvan, this is no workaround. I want to know which issues are assigned to other users.
User avatar (0027620)
istvanb (reporter)
2010-12-16 09:28

Its not, but maybe it helps for some of the users. It doesnt help if you are a manager and want to see how much issue a user has, but it help if you want to see all your issues at once.
User avatar (0027676)
daryn (reporter)
2010-12-22 13:00

The problem occurs in project api function project_get_all_user_rows. If project id is ALL_PROJECTS it only checks the global level so users with a global level lower than developer but are developers or above on specific projects are excluded. The email_notify_new_account function calls this and requires using the global level only. The mc_project_get_users function also calls it and MAY require the global level. The other calls specify a project id. I wonder if we shouldn't have an ANY_PROJECT option as well as ALL_PROJECTS. This of course would likely wreak havoc through the rest of the code as ALL_PROJECTS seems to be everywhere.
User avatar (0028883)
Lapinkiller (reporter)
2011-06-01 04:06
edited on: 2011-06-08 11:08

as soon as i find time, i will submit a patch to resolve this problem ;)

EDIT : patch submitted

User avatar (0028993)
Lapinkiller (reporter)
2011-06-14 07:32

Sorry, show-users-in-userlist-selection-when-ALL-PROJECTS-.patch doesn't work.

use filter-users-in-list-when-all_projects-selected.patch instead.

(@admins please delete first patch)
User avatar (0029003)
quentinbes (reporter)
2011-06-15 09:34

Thank you for the patch but it doesn't work for me.
I'm the only one to have some trouble ?
User avatar (0029007)
Lapinkiller (reporter)
2011-06-15 10:57
edited on: 2011-06-15 11:06

which patch have you used ? the first one i have submitted (and which is not longer attached to this bug) : show-users-in-userlist-selection-when-ALL-PROJECTS-.patch or the second : filter-users-in-list-when-all_projects-selected.patch ?

NB : the patch is for mantis 1.2.5

User avatar (0029015)
quentinbes (reporter)
2011-06-16 03:36

I used the second one but my mantis version is 1.2.3.
I tried to insert changes described in the .patch file in the source code without using git (manually).

Do you think the version I use is in conflict with your patch ?
User avatar (0029016)
Lapinkiller (reporter)
2011-06-16 03:59

maybe, i don't know...

can you try to upgrade your mantis or a copy of your mantis to 1.2.5 ?
User avatar (0031872)
M.C.S. (reporter)
2012-05-21 03:09

*push*
When will this patch make it into the official 1.2.x branch? Does it need testing? Can I help with it?
User avatar (0031875)
dregad (developer)
2012-05-21 05:01

@M.C.S.

> Does it need testing? Can I help with it?

Yes, and yes.

Please report details of your test cases and results here. You should ensure the fix works as it should, and does not cause any regression issues (filter api is quite complex, so be careful).

One of the developers can then review the results and push the commit.
User avatar (0032923)
M.C.S. (reporter)
2012-09-24 05:10

Well, I tried to apply the patch under Windows XP with "git version 1.7.8.msysgit.0" on branch "master-1.2.x" and also on the clean "release-1.2.5", but I always get these error messages when trying to apply the patch:

$git apply --check ../filter-users-in-list-when-all_projects-selected.patch
error: patch failed: core/filter_api.php:18
error: core/filter_api.php: patch does not apply
error: patch failed: core/print_api.php:19
error: core/print_api.php: patch does not apply

I called the git command from within my MantisBT root folder. Anything wrong on that?
User avatar (0032924)
Lapinkiller (reporter)
2012-09-24 09:27
edited on: 2012-09-24 09:28

i have made a new patch based on 1.2.11/1.2.x (the patch attached here was for 1.2.5 and not fully working...)
github pull request : https://github.com/mantisbt/mantisbt/pull/61 [^]

User avatar (0033009)
Lapinkiller (reporter)
2012-10-03 05:27

have you seen my patch/pull request ?
User avatar (0033015)
dregad (developer)
2012-10-03 05:49

yes but did not have time to test it yet
User avatar (0033018)
Lapinkiller (reporter)
2012-10-03 07:50

ok, no problem, i just wasn't sure you have seen it ^^
User avatar (0034537)
dregad (developer)
2012-12-12 13:06

I merged (& squashed) your commit, then made some improvements - see https://github.com/dregad/mantisbt/tree/fix-10130 [^]
User avatar (0034539)
atrol (developer)
2012-12-14 03:21
edited on: 2012-12-14 03:22

Removing the current user from list is no good idea as we lose functionality.
Creating a permalink with [Myself] (handler_id = -1) and use it by another user is another thing than using a specific handler_id in link.

User avatar (0034540)
dregad (developer)
2012-12-14 06:50

Good point, did not think about that. I'll revert the change.
User avatar (0036104)
grangeway (reporter)
2013-04-05 17:56

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master-1.2.x 21746dd1
Timestamp: 2012-09-24 13:19:54
Author: JGuilbaud
Committer: Damien Regad
Details ] Diff ]
Show all users in assign filter when ALL PROJECTS is selected

Fixes 0010130

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mod - core/filter_api.php Diff ] File ]
mod - core/print_api.php Diff ] File ]
MantisBT: master 048dc22c
Timestamp: 2012-09-24 13:19:54
Author: JGuilbaud
Committer: Damien Regad
Details ] Diff ]
Show all users in assign filter when ALL PROJECTS is selected

Fixes 0010130

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mod - core/filter_api.php Diff ] File ]
mod - core/print_api.php Diff ] File ]
MantisBT: master-1.2.x dab0021e
Timestamp: 2012-12-12 17:39:02
Author: dregad
Details ] Diff ]
Optimise code in print_user_option_list()

Improve performance of code building the list of users for all projects
introduced in commit 21746dd1a6a7e4c6df8baa9cbfc3dac48c82899c.

By using an associative array, the foreach loop to remove duplicates can
be simplified (no need for an if statement) and we can also remove the
current user from the list more easily.

Affects issue 0010130
mod - core/print_api.php Diff ] File ]
MantisBT: master dba4f3e5
Timestamp: 2012-12-12 17:39:02
Author: dregad
Details ] Diff ]
Optimise code in print_user_option_list()

Improve performance of code building the list of users for all projects
introduced in commit 21746dd1a6a7e4c6df8baa9cbfc3dac48c82899c.

By using an associative array, the foreach loop to remove duplicates can
be simplified (no need for an if statement) and we can also remove the
current user from the list more easily.

Affects issue 0010130
mod - core/print_api.php Diff ] File ]
MantisBT: master-1.2.x 748c4cec
Timestamp: 2012-12-12 17:56:03
Author: dregad
Details ] Diff ]
Removing current user from list built by print_user_option_list()

Since there is a [myself] value in the list, the current user should be
removed. This was done for ALL_PROJECTS with the fix for issue 0010130,
but the single-project code still listed the current user.

By moving the code to remove the current user to the foreach loop that
builds the sort arrays, we ensure that it is removed in both cases.
mod - core/print_api.php Diff ] File ]
MantisBT: master c7e261e1
Timestamp: 2012-12-12 17:56:03
Author: dregad
Details ] Diff ]
Removing current user from list built by print_user_option_list()

Since there is a [myself] value in the list, the current user should be
removed. This was done for ALL_PROJECTS with the fix for issue 0010130,
but the single-project code still listed the current user.

By moving the code to remove the current user to the foreach loop that
builds the sort arrays, we ensure that it is removed in both cases.
mod - core/print_api.php Diff ] File ]
MantisBT: master-1.2.x 07351732
Timestamp: 2012-12-14 13:37:52
Author: dregad
Details ] Diff ]
Do not remove current user from list

As mentioned by atrol in issue 0010130, removing the current user causes
potential loss of functionality when using filters because [myself]
(handler_id = -1) is not the same as a specific handler_id.

This is a partial revert of 748c4cec6457475673f21ad554ba1791c90222c7.
mod - core/print_api.php Diff ] File ]
MantisBT: master 0dfe2549
Timestamp: 2012-12-14 13:37:52
Author: dregad
Details ] Diff ]
Do not remove current user from list

As mentioned by atrol in issue 0010130, removing the current user causes
potential loss of functionality when using filters because [myself]
(handler_id = -1) is not the same as a specific handler_id.

This is a partial revert of 748c4cec6457475673f21ad554ba1791c90222c7.
mod - core/print_api.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2009-02-11 12:40 atrol New Issue
2009-10-22 10:31 atrol Note Added: 0023279
2010-02-18 10:34 dhx Note Added: 0024422
2010-02-18 10:34 dhx Assigned To => dhx
2010-02-18 10:34 dhx Status new => feedback
2010-02-18 11:15 atrol Note Added: 0024428
2010-02-18 11:15 atrol Status feedback => assigned
2010-02-18 21:26 stevenchew Note Added: 0024435
2010-02-19 04:20 stevenchew Note Edited: 0024435 View Revisions
2010-08-18 16:48 atrol Relationship added has duplicate 0010280
2010-11-11 03:01 atrol Relationship added has duplicate 0012501
2010-11-11 03:01 atrol Target Version => 1.2.4
2010-11-15 07:50 stevecharon Note Added: 0027363
2010-11-15 08:05 cas Note Added: 0027364
2010-12-14 21:05 jreese Target Version 1.2.4 => 1.2.5
2010-12-16 08:16 istvanb Note Added: 0027618
2010-12-16 09:07 atrol Note Added: 0027619
2010-12-16 09:28 istvanb Note Added: 0027620
2010-12-22 13:00 daryn Note Added: 0027676
2011-04-05 12:25 jreese Target Version 1.2.5 => 1.2.6
2011-06-01 04:06 Lapinkiller Note Added: 0028883
2011-06-08 11:07 Lapinkiller File Added: show-users-in-userlist-selection-when-ALL-PROJECTS-.patch
2011-06-08 11:08 Lapinkiller Note Edited: 0028883 View Revisions
2011-06-08 14:57 atrol Tag Attached: patch
2011-06-14 07:30 Lapinkiller File Added: filter-users-in-list-when-all_projects-selected.patch
2011-06-14 07:32 Lapinkiller Note Added: 0028993
2011-06-14 07:36 atrol File Deleted: show-users-in-userlist-selection-when-ALL-PROJECTS-.patch
2011-06-15 09:34 quentinbes Note Added: 0029003
2011-06-15 10:57 Lapinkiller Note Added: 0029007
2011-06-15 11:06 Lapinkiller Note Edited: 0029007 View Revisions
2011-06-16 03:36 quentinbes Note Added: 0029015
2011-06-16 03:59 Lapinkiller Note Added: 0029016
2011-07-26 09:53 jreese Target Version 1.2.6 => 1.2.7
2011-08-22 10:49 jreese Target Version 1.2.7 => 1.2.8
2011-09-06 10:33 jreese Target Version 1.2.8 => 1.2.9
2012-03-04 09:23 atrol Target Version 1.2.9 => 1.2.10
2012-04-02 02:33 atrol Target Version 1.2.10 => 1.2.11
2012-05-21 03:09 M.C.S. Note Added: 0031872
2012-05-21 05:01 dregad Note Added: 0031875
2012-06-06 23:54 jreese Target Version 1.2.11 => 1.2.12
2012-09-24 05:10 M.C.S. Note Added: 0032923
2012-09-24 09:27 Lapinkiller Note Added: 0032924
2012-09-24 09:28 Lapinkiller Note Edited: 0032924 View Revisions
2012-09-24 09:28 Lapinkiller Note Edited: 0032924 View Revisions
2012-10-03 05:27 Lapinkiller Note Added: 0033009
2012-10-03 05:49 dregad Note Added: 0033015
2012-10-03 07:50 Lapinkiller Note Added: 0033018
2012-11-10 19:04 dregad Target Version 1.2.12 => 1.2.13
2012-12-12 13:05 dregad Assigned To dhx => dregad
2012-12-12 13:06 dregad Note Added: 0034537
2012-12-13 12:36 Changeset attached => MantisBT master-1.2.x 21746dd1
2012-12-13 12:36 dregad Changeset attached => MantisBT master-1.2.x dab0021e
2012-12-13 12:36 dregad Changeset attached => MantisBT master-1.2.x 748c4cec
2012-12-13 12:36 anonymous Status assigned => resolved
2012-12-13 12:36 anonymous Resolution open => fixed
2012-12-13 12:36 anonymous Fixed in Version => 1.2.13
2012-12-13 12:36 Changeset attached => MantisBT master 048dc22c
2012-12-13 12:36 dregad Changeset attached => MantisBT master dba4f3e5
2012-12-13 12:36 dregad Changeset attached => MantisBT master c7e261e1
2012-12-14 03:21 atrol Note Added: 0034539
2012-12-14 03:21 atrol Description Updated View Revisions
2012-12-14 03:22 atrol Note Edited: 0034539 View Revisions
2012-12-14 06:50 dregad Note Added: 0034540
2012-12-14 08:43 dregad Changeset attached => MantisBT master-1.2.x 07351732
2012-12-14 08:43 dregad Changeset attached => MantisBT master 0dfe2549
2013-01-22 09:47 dregad Status resolved => closed
2013-01-22 20:15 dregad Relationship added related to 0015411
2013-04-05 17:56 grangeway Status closed => acknowledged
2013-04-05 17:56 grangeway Note Added: 0036104
2013-04-05 19:36 grangeway Relationship added related to 0015721
2013-04-06 03:39 dregad Status acknowledged => resolved
2013-04-06 07:21 grangeway Status resolved => acknowledged
2013-04-06 09:22 dregad Tag Attached: 2.0.x check
2013-04-06 09:23 dregad Status acknowledged => closed
2014-09-23 18:05 grangeway Tag Detached: 2.0.x check


MantisBT 1.2.17 [^]
Copyright © 2000 - 2014 MantisBT Team
Time: 0.1668 seconds.
memory usage: 3,353 KB
Powered by Mantis Bugtracker