MantisBT: master b433e7e6

Author Committer Branch Timestamp Parent
cproensa dregad master 2016-04-29 13:13 master 837d9a60
Affected Issues  0017577: Improve print_user_option_list() performance
Changeset

Don't cache users in project_get_all_user_rows()

Most of the callers of project_get_all_user_rows use the return array
directly, and do not need to fetch the user rows. There's no need to
always cache the calculated users. Especially when the user list is very
large, eg: print users option list with public access. By not caching
them, memory and time is saved (see issue 0017577)

Of all the callers of this function, those that actually use the
cached data are:

  • email_notify_new_account(): Adds an explicit call to cache
  • email_collect_recipients(): Was already calling to cache users

Signed-off-by: Damien Regad dregad@mantisbt.org

mod - core/email_api.php Diff File
mod - core/project_api.php Diff File